From 9825f08f2b46b147faa48e4d127c93694522e6d6 Mon Sep 17 00:00:00 2001 From: fusion32 Date: Thu, 16 Oct 2025 02:00:22 -0300 Subject: prevent a few SQLite queries to fail when they affected no rows This was done with the old design in mind, but with the query thread offloading, returning false is meant to signal a failure in completing it. A connection lost with PostgreSQL or BUSY error with SQLite, for example. --- src/database_sqlite.cc | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) (limited to 'src/database_sqlite.cc') diff --git a/src/database_sqlite.cc b/src/database_sqlite.cc index bcc4914..35581a4 100644 --- a/src/database_sqlite.cc +++ b/src/database_sqlite.cc @@ -1128,7 +1128,7 @@ bool IncrementIsOnline(TDatabase *Database, int WorldID, int CharacterID){ return false; } - return sqlite3_changes(Database->Handle) > 0; + return true; } bool DecrementIsOnline(TDatabase *Database, int WorldID, int CharacterID){ @@ -1156,7 +1156,7 @@ bool DecrementIsOnline(TDatabase *Database, int WorldID, int CharacterID){ return false; } - return sqlite3_changes(Database->Handle) > 0; + return true; } bool ClearIsOnline(TDatabase *Database, int WorldID, int *NumAffectedCharacters){ @@ -1218,7 +1218,7 @@ bool LogoutCharacter(TDatabase *Database, int WorldID, int CharacterID, int Leve return false; } - return sqlite3_changes(Database->Handle) > 0; + return true; } bool GetCharacterIndexEntries(TDatabase *Database, int WorldID, int MinimumCharacterID, @@ -1292,7 +1292,7 @@ bool InsertCharacterDeath(TDatabase *Database, int WorldID, int CharacterID, int return false; } - return sqlite3_changes(Database->Handle) > 0; + return true; } bool InsertBuddy(TDatabase *Database, int WorldID, int AccountID, int BuddyID){ @@ -1697,7 +1697,7 @@ bool UpdateHouseOwner(TDatabase *Database, int WorldID, int HouseID, int OwnerID return false; } - return sqlite3_changes(Database->Handle) > 0; + return true; } bool DeleteHouseOwner(TDatabase *Database, int WorldID, int HouseID){ @@ -1722,7 +1722,7 @@ bool DeleteHouseOwner(TDatabase *Database, int WorldID, int HouseID){ return false; } - return sqlite3_changes(Database->Handle) > 0; + return true; } bool GetHouseOwners(TDatabase *Database, int WorldID, DynamicArray *Owners){ @@ -1907,7 +1907,7 @@ bool ExcludeFromAuctions(TDatabase *Database, int WorldID, int CharacterID, int return false; } - return sqlite3_changes(Database->Handle) > 0; + return true; } // Banishment Tables @@ -2497,7 +2497,7 @@ bool CheckOnlineRecord(TDatabase *Database, int WorldID, int NumCharacters, bool return false; } - *NewRecord = sqlite3_changes(Database->Handle) > 0; + *NewRecord = (sqlite3_changes(Database->Handle) > 0); return true; } -- cgit v1.2.3