From 748f676ea6474053e592f47804da27d4b9e49041 Mon Sep 17 00:00:00 2001 From: fusion32 Date: Sat, 13 Sep 2025 02:20:28 -0300 Subject: remove ParseOptionalIPAddress I had just added it in the last commit but it made its use case non-obvious. Checking whether the string is empty before trying to parse an IP address is clearer than calling some function that has its own concept of what an empty address is. --- src/connections.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'src/connections.cc') diff --git a/src/connections.cc b/src/connections.cc index d032ce5..480cc1e 100644 --- a/src/connections.cc +++ b/src/connections.cc @@ -918,7 +918,7 @@ void ProcessSetNamelockQuery(TConnection *Connection, TReadBuffer *Buffer){ Buffer->ReadString(Comment, sizeof(Comment)); int IPAddress = 0; - if(!ParseOptionalIPAddress(IPString, &IPAddress)){ + if(!StringEmpty(IPString) && !ParseIPAddress(IPString, &IPAddress)){ SendQueryStatusFailed(Connection); return; } @@ -978,7 +978,7 @@ void ProcessBanishAccountQuery(TConnection *Connection, TReadBuffer *Buffer){ bool FinalWarning = Buffer->ReadFlag(); int IPAddress = 0; - if(!ParseOptionalIPAddress(IPString, &IPAddress)){ + if(!StringEmpty(IPString) && !ParseIPAddress(IPString, &IPAddress)){ SendQueryStatusFailed(Connection); return; } @@ -1045,7 +1045,7 @@ void ProcessSetNotationQuery(TConnection *Connection, TReadBuffer *Buffer){ Buffer->ReadString(Comment, sizeof(Comment)); int IPAddress = 0; - if(!ParseOptionalIPAddress(IPString, &IPAddress)){ + if(!StringEmpty(IPString) && !ParseIPAddress(IPString, &IPAddress)){ SendQueryStatusFailed(Connection); return; } -- cgit v1.2.3