From d359c0af4874534efa810729d47f610a29687e93 Mon Sep 17 00:00:00 2001 From: fusion32 Date: Sat, 19 Jul 2025 11:35:11 -0300 Subject: THREADING: upgrade from LinuxThreads to NPTL This was a required change to make the server run on a modern GLIBC version without resorting to shady shared libraries or compatibility tricks. It is very straightforward but we should always keep an eye out for possible bugs. There was also a problem with the Z loop on field sending functions that was causing the server to hang in an infinite loop and should now be fixed. With these changes it is now possible to login into the game for a split second before the client asserting. --- TODO.md | 5 ----- 1 file changed, 5 deletions(-) (limited to 'TODO.md') diff --git a/TODO.md b/TODO.md index 165acd0..d1352f7 100644 --- a/TODO.md +++ b/TODO.md @@ -1,11 +1,6 @@ ## Synchronization I'm not sure whether synchronization is done properly. The implementation of the first few `crplayer.cc` functions left me with a taste of race conditions although integer loads on x86 are generally atomic. -## Threading -After some initial dive into `communication.cc`, it has become clear that the original codebase relied on `LinuxThreads` which, among its quirks, assigns different PIDs to different threads, explaining the usage of `getpid()`. It also seems it could lack automatically managed thread stacks which explains `CommunicationThreadStacks`. - -We'll have to address this BEFORE trying to run the server. - ## TODO (LEFTOVER) - Include `x == 0xFFFF` inside `CheckVisibility`? - The map container uses type id zero but it seems to also be used as a "no type" -- cgit v1.2.3